Support installing a specific ddev version #13 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
reviewed
Oct 28, 2023
.github/workflows/main.yml
Outdated
Comment on lines
21
to
25
| if [[ ${{ matrix.version }} == '1.22.3' ]]; then | ||
| test $(ddev --version) == 'ddev version v1.22.3' | ||
| else | ||
| test $(ddev --version) != 'ddev version v1.22.3' | ||
| fi |
There was a problem hiding this comment.
This seems too fragile; can we do something less specific? What's the purpose of this exact stanza?
There was a problem hiding this comment.
When using latest as the ddev version, then the version will change over time. This basically checks that if the version is specified, it matches, and if not, it can never match (now that 1.22.4 is out).
I'm open to suggestions here!
There was a problem hiding this comment.
That looks good to me as a test.
jonaseberle
approved these changes
Oct 30, 2023
|
This looks and feels very good, thank you @deviantintegral! |
|
Not from me! We've been using this for nearly a week to work around https://github.com/orgs/ddev/discussions/5470. |
|
v1.9.0 is released with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
See #13 and jonaseberle/github-action-setup-ddev#15.
How This PR Solves The Issue
If version is specified, we pass that to apt and then hold the package so upgrades won't automatically upgrade it.
Manual Testing Instructions
Automated Testing Overview
This adds a matrix to test both cases for version.